Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'tag' template helper within renderer #224

Open
Flauschbaellchen opened this issue Jun 21, 2020 · 1 comment
Open

Support 'tag' template helper within renderer #224

Flauschbaellchen opened this issue Jun 21, 2020 · 1 comment

Comments

@Flauschbaellchen
Copy link

If using a custom renderer it is not possible to use the tag helper which is a shorter variant for content_tag and is preferred by Rails style guides.
The SimpleNavigation::Renderer::Base does not delegate tag to the template adapter.

Documentation:
rails/rails#25195
https://docs.rubocop.org/rubocop-rails/cops_rails.html#railscontenttag

It would be great to see this implemented.
Currently I've excluded any renderers from Rubocop's auto-correction feature.

@andi
Copy link
Collaborator

andi commented Jun 23, 2020

It would be great if you could contribute with a PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants