From 3f0cc86b6336a689d15a5525461843b78db147a8 Mon Sep 17 00:00:00 2001
From: cmoussa1 <moussa1@llnl.gov>
Date: Fri, 24 Jan 2025 16:36:39 -0800
Subject: [PATCH] t: add tests for a job ID with multiple formats

Problem: There are no tests for calling view-job-records --jobid where
the format of --jobid is in multiple formats, such as f58, hex, dothex,
etc.

Add some basic tests.
---
 t/Makefile.am      |  1 +
 t/t1046-issue564.t | 88 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+)
 create mode 100755 t/t1046-issue564.t

diff --git a/t/Makefile.am b/t/Makefile.am
index 0366d1a0..6ff8272c 100644
--- a/t/Makefile.am
+++ b/t/Makefile.am
@@ -45,6 +45,7 @@ TESTSCRIPTS = \
 	t1043-view-jobs-by-bank.t \
 	t1044-mf-priority-resource-limits.t \
 	t1045-issue478.t \
+	t1046-issue564.t \
 	t5000-valgrind.t \
 	python/t1000-example.py \
 	python/t1001_db.py \
diff --git a/t/t1046-issue564.t b/t/t1046-issue564.t
new file mode 100755
index 00000000..67d6c294
--- /dev/null
+++ b/t/t1046-issue564.t
@@ -0,0 +1,88 @@
+#!/bin/bash
+
+test_description='test viewing jobs with different ID formats'
+
+. `dirname $0`/sharness.sh
+MULTI_FACTOR_PRIORITY=${FLUX_BUILD_DIR}/src/plugins/.libs/mf_priority.so
+SUBMIT_AS=${SHARNESS_TEST_SRCDIR}/scripts/submit_as.py
+DB_PATH=$(pwd)/FluxAccountingTest.db
+
+export TEST_UNDER_FLUX_NO_JOB_EXEC=y
+export TEST_UNDER_FLUX_SCHED_SIMPLE_MODE="limited=1"
+test_under_flux 1 job
+
+flux setattr log-stderr-level 1
+
+test_expect_success 'load multi-factor priority plugin' '
+	flux jobtap load -r .priority-default ${MULTI_FACTOR_PRIORITY}
+'
+
+test_expect_success 'check that mf_priority plugin is loaded' '
+	flux jobtap list | grep mf_priority
+'
+
+test_expect_success 'create flux-accounting DB' '
+	flux account -p ${DB_PATH} create-db
+'
+
+test_expect_success 'start flux-accounting service' '
+	flux account-service -p ${DB_PATH} -t
+'
+
+test_expect_success 'add banks to the DB' '
+	flux account add-bank root 1 &&
+	flux account add-bank --parent-bank=root bankA 1
+'
+
+test_expect_success 'add a user with a list of projects to the DB' '
+	flux account add-user --username=user1 --userid=5001 --bank=bankA
+'
+
+test_expect_success 'send flux-accounting DB information to the plugin' '
+	flux account-priority-update -p ${DB_PATH}
+'
+
+test_expect_success 'submit a job' '
+	job1=$(flux python ${SUBMIT_AS} 5001 hostname) &&
+	flux job wait-event -f json $job1 priority &&
+	flux cancel $job1
+'
+
+test_expect_success 'run fetch-job-records script' '
+	flux account-fetch-job-records -p ${DB_PATH}
+'
+
+test_expect_success 'call view-job-records with f58 job ID' '
+	flux account view-job-records --jobid ${job1} > f58_id.out &&
+	test $(grep -c "bankA" f58_id.out) -eq 1
+'
+
+test_expect_success 'call view-job-records with hex job ID' '
+	job1_hex=$(flux job id -t hex ${job1}) &&
+	flux account view-job-records --jobid ${job1_hex} > hex_id.out &&
+	test $(grep -c "bankA" hex_id.out) -eq 1
+'
+
+test_expect_success 'call view-job-records with kvs job ID' '
+	job1_kvs=$(flux job id -t kvs ${job1}) &&
+	flux account view-job-records --jobid ${job1_kvs} > kvs_id.out &&
+	test $(grep -c "bankA" kvs_id.out) -eq 1
+'
+
+test_expect_success 'call view-job-records with dothex job ID' '
+	job1_dothex=$(flux job id -t dothex ${job1}) &&
+	flux account view-job-records --jobid ${job1_dothex} > dothex_id.out &&
+	test $(grep -c "bankA" dothex_id.out) -eq 1
+'
+
+test_expect_success 'call view-job-records with words job ID' '
+	job1_words=$(flux job id -t words ${job1}) &&
+	flux account view-job-records --jobid ${job1_words} > words_id.out &&
+	test $(grep -c "bankA" words_id.out) -eq 1
+'
+
+test_expect_success 'shut down flux-accounting service' '
+	flux python -c "import flux; flux.Flux().rpc(\"accounting.shutdown_service\").get()"
+'
+
+test_done