Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is grpc-port=<port> supported? #20

Open
lightningorb opened this issue Aug 13, 2022 · 4 comments
Open

is grpc-port=<port> supported? #20

lightningorb opened this issue Aug 13, 2022 · 4 comments

Comments

@lightningorb
Copy link
Contributor

Hi,

Still very noob so please ignore any mistake i make here. But it seems the way the GRPC API is now enabled is with either supplying --grpc-port= to lightningd, or adding grpc-port= to the config file.

This has been tried by modifying the config file, or hacking 03-lightning-setup.sh however things seem to break (no certs, and cl-rest seems to break).

Can this be supported? Also happy to flesh out some example projects [#10]. I've got the REST api to work with workbench, and the GRPC API to work on what is soon to be my main node. But not vice-versa.

@lightningorb
Copy link
Contributor Author

It just occurred to me the cargo deps are required for this to work.

@cmdruid
Copy link
Owner

cmdruid commented Aug 16, 2022

Honestly I haven't played around with gRPC for core lightning, and I haven't seen much documentation on it. Do you have any good resources?

@lightningorb
Copy link
Contributor Author

Not really besides reading the contents of node_pb2.py and node_pb2_grpc.py (the generated .py from .proto files). also https://github.com/ElementsProject/lightning/blob/master/contrib/pyln-testing/pyln/testing/grpc.py

@lightningorb
Copy link
Contributor Author

For the record, adding cargo to clightning.dockerfile was fine, however rustfmt needs debian bookworm, which had a missing pubkey error so docker refused to install packages.

I'm seeing that the GRPC API is quite behind, while the REST API especially due to the /rpc endpoint has no limitations. Might be a matter of waiting for the GRPC APi to mature some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants