Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor formatAmount #589

Open
yuetloo opened this issue Nov 10, 2022 · 0 comments
Open

refactor formatAmount #589

yuetloo opened this issue Nov 10, 2022 · 0 comments
Assignees
@yuetloo

Comments

@yuetloo
Copy link
Collaborator

yuetloo commented Nov 10, 2022

Need to refactor formatAmount https://github.com/clrfund/monorepo/blob/develop/vue-app/src/utils/amounts.ts#L4 by breaking it down into different functions to handle separately input as string, FixedNumber, BigNumber, max decimal and significant digits.

  • need to remove the code that could convert big number to unsafe javascript number.
  • various places also call this function with hardcoded token decimal of 18
@yuetloo yuetloo self-assigned this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuetloo yuetloo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuetloo