[Bug] @ts-ignore in cloudinary-loader.ts #425
Assignees
Labels
Comments
|
Hi, I'd like to work on this issue |
|
we'll start with the other issue and can work on other issues 1 by 1 unless someone else takes it first. thanks |
|
Hi @colbyfayock, I would love to work on this. I just completed the #541 PR |
|
sure thing! |
12 tasks
|
@colbyfayock I have sent in a PR for this. |
colbyfayock
added a commit
that referenced
this issue
Nov 1, 2024
# Description This PR will add the `src` type to `CloudinaryLoaderCldOptions` interface to fix the ts error being thrown from the `cloudinary-loader.ts` file. Fixes This will close #425 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/cloudinary-community/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/cloudinary-community/next-cloudinary/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/cloudinary-community/next-cloudinary/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes needed to the documentation --------- Co-authored-by: Colby Fayock <[email protected]>
|
🎉 This issue has been resolved in version 7.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@colbyfayock I think we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Describe the bug
A @ts-ignore is currently in place in the cloudinaryLoader function which is what organizes and ultimately helps to build a Cloudinary URL based on Next.js props.
https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/loaders/cloudinary-loader.ts#L58-L59
Goal wouild be to address whatever type issues are preventing this line from being removed.
The text was updated successfully, but these errors were encountered: