-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] CldVideoPlayer load error (Next 13) #279
Comments
hey @leebaduk thanks for reporting this. strange behavior here and havent pinned down the issue yet. Are you noticing this when all the videos are different sources as well? do you have a specific use case for this many instances of the same video? |
@colbyfayock sorry i got back to you late but i use router.replace(query parameter) on my app to search the videos. so, even though I don't have a specific case for many instances of the same video, it still matters practically. |
ah got it, yeah that makes sense, thanks for your patience on this bug, will try to get to it soon |
just adding i was able to reproduce this by simply playing the videos on the Basic Usage page, navigating away, playing videos on another page, and navigating back |
@colbyfayock I would like to work on this issue. Can you assign it to me ? |
yes @JoshuaRotimi all yours! |
…317) # Description This PR fixes the issue #279 where some players fail to load when rendering multiple `CldVideoPlayer` on one page. - Also fixes the issue where the `CldVideoPlayer` component fails to render properly after navigating between pages - Also adds a cleanup function that removes the widget instance when a `CldUploadWidget` component unmount ## Issue Ticket Number #279 Fixes #<ISSUE_NUMBER> <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes needed to the documentation --------- Co-authored-by: Colby Fayock <[email protected]>
@leebaduk the latest release should improve the reliability of this, but there's still an issue where the Next.js Script tag won't reliably fire on every single onLoad instance. trying to determine a way to resolve this, but in the meantime, hoping this greatly helps |
if anyone would like ot help with this - can someone reproduce the issue of using the the loading mechanism can be displayed using console logs if this is reproducible outside of the context of this library, i can take it to the Next.js team or raise an Issue |
# [5.4.0](cloudinary-community/next-cloudinary@v5.3.0...v5.4.0) (2023-11-09) ### Features * dispose of upload widget and video player instance on unmount ([#317](cloudinary-community/next-cloudinary#317)) ([a313b7a](cloudinary-community/next-cloudinary@a313b7a)), closes [#279](cloudinary-community/next-cloudinary#279) [#279](cloudinary-community/next-cloudinary#279)
Bumping as we are running into this scenario. Anywhere we render a list of CldVideoPlayer there may be a one or more "blanks". Seems to be reliably triggered by repeated client side navigation (latest next 14 app dir). It's almost as if it renders a fallback I don't have the bandwidth to perform that sandbox repro but I'm able to cooperate here, let me know if you all have found any solutions. |
This issue has not been fixed yet. I have similar issue on two apps I have built with this package. |
I'm experiencing a similar issue with multiple rendering of CldVideoPlayer. |
Bug Report
Describe the bug
When rendering multiple CldVideoPlayers on one page, some of the players fail to load a video (while others work fine, which is odd).
For example when I render 20 players on 5*4 grid which share the same
src
, 3 or 4 of them would be shown as a white blank randomly.Is this a regression?
not sure
Steps To Reproduce the error
.env
on root withNEXT_PUBLIC_CLOUDINARY_CLOUD_NAME=dlz0shbp1
(this is my cloud name)npm i
npm run dev
Expected behaviour
all the videos should be successfully loaded.
CodeSandbox or Live Example of Bug
codesandbox available here, just the same as the repo above;
https://codesandbox.io/p/sandbox/next-cloudinary-test-y5hssp
Screenshot or Video Recording
Your environment
Additional context
The text was updated successfully, but these errors were encountered: