Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same Time* for sflow even if they are different #121

Open
galushka opened this issue Sep 8, 2023 · 0 comments
Open

Same Time* for sflow even if they are different #121

galushka opened this issue Sep 8, 2023 · 0 comments

Comments

@galushka
Copy link

galushka commented Sep 8, 2023

Firstly, thank you for the library.
In the goflow/utils/sflow.go file, there are the following blocks of code:

  1. Defining "ts":
ts := uint64(time.Now().UTC().Unix())
if pkt.SetTime {
    ts = uint64(pkt.RecvTime.UTC().Unix())
}
  1. Setting TimeReceived, TimeFlowStart, and TimeFlowEnd:
for _, fmsg := range flowMessageSet {
    fmsg.TimeReceived = ts
    fmsg.TimeFlowStart = ts
    fmsg.TimeFlowEnd = ts
}

Currently, there is no difference between TimeFlowStart / TimeFlowEnd and TimeReceived. However, when the flag "SetTime" is set to "true", it would be very useful to distinguish between these timestamps.
Thank you!

tgragnato pushed a commit to tgragnato/goflow that referenced this issue Aug 14, 2024
This pull request adds the optional -transport.kafka.scram flag,
which tells the Kafka transport to use SASL/SCRAM for authentication.
This allows goflow2 to work with AWS Managed Service for Kafka (MSK)
which does not support SASL/PLAIN.

Co-authored-by: Brian Landers <[email protected]>
Co-authored-by: lspgn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant