Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated querystring config #226

Open
bengerman13 opened this issue Dec 3, 2021 · 1 comment
Open

use updated querystring config #226

bengerman13 opened this issue Dec 3, 2021 · 1 comment

Comments

@bengerman13
Copy link
Contributor

In order to keep the broker maintainable and understandable, we want to use QueryStringsConfig when calling create/updateDistribution on cloudfront distributions, rather than ForwarededValues.QueryString

For now, we should match the existing behavior, which is to forward all query strings and cache on all query strings

Security considerations

This does not effect security

@bengerman13
Copy link
Contributor Author

AWS doesn't seem to be removing this functionality soon, and the new config is going to hit service limits quickly. We should talk with AWS about timeline for deprecation and hard limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant