Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit heading level/usage in success messages #532

Open
1 task
beepdotgov opened this issue Sep 26, 2024 · 0 comments
Open
1 task

Revisit heading level/usage in success messages #532

beepdotgov opened this issue Sep 26, 2024 · 0 comments
Labels
Bug Something isn't working Research something we need to figure out before we can build squad-dashboard UI user interface component and styling implementation

Comments

@beepdotgov
Copy link
Contributor

Noticed this during today’s a11y jam: success messages are using an h4 for the bolded text, which breaks the page’s heading level:

Screenshot 2024-09-26 at 1 15 54 PM

Jumping from h1 to h4 isn’t a sequential order, which is unintuitive for folks navigating by heading level.

(I’m actually not sure if that text needs to be marked up as a heading! But if we think it does, these messages should use a heading level that fits into the page’s broader document outline.)

Can this task be done in one increment?

Unsure; marking as research.

Ensure this issue has a clear Definition of Done in the Acceptance Criteria list below:

Acceptance Criteria

  • The success messages shouldn’t break the page’s heading outline.
@beepdotgov beepdotgov added Bug Something isn't working squad-dashboard UI user interface component and styling implementation Research something we need to figure out before we can build labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Research something we need to figure out before we can build squad-dashboard UI user interface component and styling implementation
Projects
None yet
Development

No branches or pull requests

1 participant