-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When closing an overlay drawer, the success message isn’t announced [Safari/VoiceOver] #531
Comments
Consider trying out this approach (now an NPM package) - original thread |
Here are my findings from taking a few days to research this issue: In most cases, our live regions are USWDS Alerts. Since the app updates success messages dynamically (like with other alerts), we want them to be read with the same level of urgency. Upgrading success alerts to You can see how all types of alerts are read on any page form:
This can also be observed with pending and error alerts in form overlays:
I believe this narrows down the problem described in this issue to the specific workings of the Manage Users page. When closing an overlay, the success alert that shows up on the top of the page is still inconsistently read. When an overlay is closed, we refocus the user back to the last point of regard on the page before the overlay was opened. My theory is there's confusion between the SR wanting to read wherever you're refocusing to (like a table cell) instead of reading the success alert at the top of the page. I recommend exploring this approach:
This approach could have the added benefit of fixing issues like #544 where it's unclear what's been changed in a success message. (Keeping the user in the form will show exactly what's been changed.) |
I also took the time to experiment with using React's Context API to handle aria live messages. The packages linked above weren't compatible with React 18, so I created a custom prototype to demonstrate how Context can be used for this. I believe this approach could be used in the future, for global invisible alerts to be read. But I see no current use cases for it, as our current use cases deal with visible USWDS Alerts that should be read instead. This can be seen on the branch eoc/531-context. |
Just logging two things for myself before tomorrow’s jam: |
Our TODO's from our discussion at a11y jam are:
These are done in #581 |
After successfully completing a task in an overlay drawer, the drawer closes, and focus returns to the table. (#496) Unfortunately, the success message isn’t announced by VoiceOver, so there’s no indication that the transaction successfully completed.
Here’s a screen recording of this behavior:
overlay.close.mov
(No audio, sorry; couldn’t find a way to do that on macOS.)
Can this task be done in one increment?
Unknown; marking as research.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: