-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recurrent events now break plugin completely. What has changed? #96
Comments
Looking at the console, there are 983 messages from the plugin (no errors) — of which this is a typical fragment :
A screenshot of the console log: |
Thanks for the report. When I moved the repo I updated the My apologies. You can try the previous release of you'd like while I revert the dependency upgrade in the next few hours. |
Reverting back to 0.16.1 |
@seatrout - what calendar providers are you using? I'm trying to reproduce the issue and I don't see the issue with Google Calendar feeds. |
I tried O365 calendars too without being able to reproduce. From looking at the provided screenshot I see |
I'm using Google. I don't know where the Apple thing came from, except that one of these Google calendars is shared with my wife, who does keep an Apple calendar. |
The "RMC Editorial meetings" may also be shared with people who use Apple providers. But most of the calendars referenced in the file are Google, even if they are shared. |
Do shared calendars put out a different ICS feed/ That seems very unlikely to me, but what would I know? |
You are correct, they should not be any different. @seatrout - can you try the release before the update? https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.0 . Replace |
Oh, and you'll need to restart Obsidian before trying to re-import |
Yay! That works again. Thank you — what exactly changed to break things? |
I haven't changed anything yet. ;) 1.5.0 works for you? |
Just to confirm: 1.50 works again, yes. |
So it was the update in |
I believe so, which in turn pulled in changes to I'd rather not revert to 0.16.1 as it's showing a dependency on a vulnerable
I am exploring other options now, would love help testing once I get an idea... |
k, looks like I can lock |
Happy to help test this |
@seatrout , https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.1-lockrrule3 works for me locally (but I never suffered the breakage). In this release I keep the update to Hoping this no longer shows the erroneous recurring events for you when you try it. You'll replace the Thanks! |
One more https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.1-lockrrule4 - this uses the last |
It's all part of the cost of being able to make computers do all the things they do. ;) |
Actually, I realized that the above build still had the older @seatrout : Please let me know if the latest, https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.3 release maintains the fix and we can close this. If you're still seeing it, I am sure we can find some other solution... |
Is it only main.js that's changed and needs replacing? |
Yes. if you want the version number to show up correctly that's in |
The 1.5.3 version works, both when there is an event that day, whether it recurs or not, and when there are none. Thank you so much. |
Thanks for the report and helping test. I wish I could reproduce the issue so I can test against whatever is going wrong in future releases. For now I'll count on you and other users to let me know if the issue comes back. ;) |
Everything still works, and I am still grateful :-) |
😌 , phew, I was worried the issue came back the next day when I saw the email notification!
Thanks @seatrout , I'll see if that helps in reproducing the issue. |
For the last five days, the plugin has been horrible broken: it finds huge numbers of recurrent events from past years ands spews them into my daily note, complaining about "Invalid date" — this with a template that was working perfectly well before Christmas.
Using this template fragment (adjusted to fit the way I name my diaries):
I get hundreds of lines complaining of "Invalid date" in recurring events that have long since passed, and don't in any case affect today:
like this:
I have tried this with a conventionally named date template too: it is clearly something in the handling of recurrent events in the plugin.
The text was updated successfully, but these errors were encountered: