Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock ckeditor5-dev-* packages to the latest stable version #191

Closed
pomek opened this issue Sep 27, 2024 · 0 comments · Fixed by #193
Closed

Lock ckeditor5-dev-* packages to the latest stable version #191

pomek opened this issue Sep 27, 2024 · 0 comments · Fixed by #193
Assignees
@psmyrek
Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 79

Comments

@pomek
Copy link
Member

pomek commented Sep 27, 2024

Provide a description of the task

Due to the upcoming release of breaking changes in the ckeditor5-dev-* (PR) packages that also require changes in CKEditor 5 code base (PR), we must lock a version of the @ckeditor/ckeditor5-dev-build-tools package.

ckeditor5-package-generator/packages/ckeditor5-package-generator/lib/utils/get-dependencies-versions.js

Line 37 in 19f27a4

ckeditor5DevBuildTools: getPackageVersion( '@ckeditor/ckeditor5-dev-build-tools' ),

The current implementation will use the upcoming release, which will break the tool. Hence, we must use the 43.0.0 version.
@pomek pomek added squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Sep 27, 2024
@pomek pomek mentioned this issue Sep 27, 2024
Closed
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 27, 2024
@psmyrek psmyrek mentioned this issue Sep 30, 2024
Merged
@pomek pomek closed this as completed in c5beffb Sep 30, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 30, 2024
@CKEditorBot CKEditorBot added this to the iteration 79 milestone Sep 30, 2024
pomek added a commit that referenced this issue Sep 30, 2024
@pomek
Merge pull request #193 from ckeditor/i/191
d031bb0 
Other (generator): Lock to the last compatible version of the `@ckeditor/ckeditor5-dev-build-tools` package due to the upcoming release of breaking changes in the `@ckeditor/ckeditor5-dev-*` packages. Closes #191.
@pomek pomek removed their assignment Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 79
3 participants
@pomek @CKEditorBot @psmyrek