-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@ckeditor/ckeditor5-watchdog latest update issue #356
Comments
I managed to fix it by adding this: declare module '@ckeditor/ckeditor5-watchdog/src/watchdog' {
const WatchdogConfig: any;
type WatchdogConfig = any;
export default WatchdogConfig;
} |
Hi @Nightcro, Thanks for reaching out. Looks like the issue is reproducible, so thank you for bringing it to our attention. Precise steps on how to reproduce with a fresh Angular app:
Running @pomek let me know if you want me to retest this. |
Ok, so as long as CKEditor 5 Angular component uses the Watchdog feature from the JS version of the code, we must include typings as a dependency too. Thanks @mabryl, for confirming the issue. We will let you know once we release the solution. I hope it will next week. |
Fixed for me. Thanks! |
@Nightcro I do get the following error while trying your fix.
Where did you have added this piece of code ? |
This was fixed with the latest release of ckeditor, you do not need these typings anymore. https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-37.html I will close this issue |
Thx @Nightcro, I still have the error though, I did a add a pull request that helped me solve the problem |
Hello, after updating to latest version, I get this error. I do not have @ckeditor/ckeditor5-watchdog in my package.json.
Error: node_modules/@ckeditor/ckeditor5-angular/ckeditor.component.d.ts:7:28 - error TS7016: Could not find a declaration file for module '@ckeditor/ckeditor5-watchdog/src/watchdog'. /node_modules/@ckeditor/ckeditor5-angular/node_modules/@ckeditor/ckeditor5-watchdog/src/watchdog.js' implicitly has an 'any' type.
Try
npm i --save-dev @types/ckeditor__ckeditor5-watchdog
if it exists or add a new declaration (.d.ts) file containingdeclare module '@ckeditor/ckeditor5-watchdog/src/watchdog';
7 import WatchdogConfig from '@ckeditor/ckeditor5-watchdog/src/watchdog';
The text was updated successfully, but these errors were encountered: