Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out permissions to a separate JSON file #1356

Open
buidav opened this issue Oct 7, 2024 · 1 comment · May be fixed by #1380
Open

Abstract out permissions to a separate JSON file #1356

buidav opened this issue Oct 7, 2024 · 1 comment · May be fixed by #1380
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Oct 7, 2024

💡 Summary

For regular update and maintenance of ScubaGear, the permissions required of the module should be abstracted to a separate file instead of coded with the authentication module. This is so scripts or other code utilizing ScubaGear can check for permission ScubaGear permission updates and automatically notify or update permissions itself if using a Service Principal.

Motivation and context

Easier future maintenance of ScubaGear permissions for code utilizing ScubaGear.

Implementation notes

  • Abstract out the MS Graph API permissions in Connection.psm1 to a permissions JSON file.
  • Add Service Principal Permissions to the JSON file.
  • Keep permissions for both Commercial (including GCC) and Government (GCC High) in the JSON file.

Acceptance criteria

  • Permissions for ScubaGear are abstracted out to some permissions JSON file.
  • A cmdlet is added to read and display the information in the JSON file.
  • This permissions file is noted in the documentation.
@buidav buidav added the enhancement This issue or pull request will add new or improve existing functionality label Oct 7, 2024
@schrolla schrolla added this to the Backlog milestone Oct 14, 2024
@schrolla
Copy link
Collaborator

Blocked while continuing discussions on implementation details.

@buidav buidav linked a pull request Oct 28, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants