Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect symbols used for Immersive Audio Data Essence Descriptor and SubDescriptor #15

Open
palemieux opened this issue Sep 25, 2019 · 0 comments
Open

Incorrect symbols used for Immersive Audio Data Essence Descriptor and SubDescriptor #15

palemieux opened this issue Sep 25, 2019 · 0 comments

Comments

@palemieux
Copy link
Contributor

The library currently outputs:

060e2b34.02530105.0e090603.00000000  len:     120 (PrivateDCDataDescriptor)
             InstanceUID = f6417a2c-80a3-46ad-91a7-e19878fabff9
                Locators:
          SubDescriptors:
  a82aa922-ccf2-4494-8b86-d45a8c6040ba
           LinkedTrackID = 2
              SampleRate = 24/1
       ContainerDuration = 27768
        EssenceContainer = 060e2b34.04010105.0e090605.00000000
       DataEssenceCoding = 060e2b34.04010105.0e090604.00000000

060e2b34.02530105.0e090606.00000000  len:      65 (DolbyAtmosSubDescriptor)
             InstanceUID = a82aa922-ccf2-4494-8b86-d45a8c6040ba
                 AtmosID = 4395698a-3c22-4ab1-b3d4-b6784dba9a65
              FirstFrame = 0
         MaxChannelCount = 10
          MaxObjectCount = 118
            AtmosVersion = 1

Instead the symbols defined in the SMPTE register should be used. For example, PrivateDCDataDescriptor should be IADataEssenceDescriptor and DolbyAtmosSubDescriptor should be IADataEssenceSubDescriptor
@palemieux palemieux mentioned this issue Mar 11, 2020
Closed
jhursty added a commit that referenced this issue Sep 12, 2021
@jhursty
Merge pull request #15 from DolbyLaboratories/dolby/atmos_storage/asd…
3e71fd6 
…cplib_integration/templatize_h02writerclip_depends_on_pluggable_filereader

Templatize h__AS02WriteClip, move functions definition to header. Note that this depends on filereader pluggable at runtime commit as the reader is called as a pointer here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced ATMOS with IAB terminology cinecert/asdcplib
1 participant
@palemieux