Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

Support for reverse DCC SEND #248

Open
obfuscoder opened this issue Aug 15, 2017 · 0 comments
Open

Support for reverse DCC SEND #248

obfuscoder opened this issue Aug 15, 2017 · 0 comments

Comments

@obfuscoder
Copy link

At the moment cinch does not support reverse dcc sends.

https://en.wikipedia.org/wiki/Direct_Client-to-Client#Reverse_.2F_Firewall_DCC

It doesn't detect these messages and never fires the dcc_send event. This is due to the regex used:

message =~ /^\001DCC SEND (?:"([^"]+)"|(\S+)) (\S+) (\d+)(?: (\d+))?\001$/

For reverse DCCs the port is set to 0 and the filesize is followed by an additional parameter - a token.

The first step towards supporting reverse DCCs would be to detect them by updating the regex.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant