Make PID file path configurable in ksmbd.conf

[farnoy]

Right now, the location of the PID file is hardcoded at compile time and can be changed with --with-rundir. Is there a reason this can't be a runtime choice, same as --config or --users?

SYSCONFDIR is also hardcoded in the same way:

ksmbd-tools/include/tools.h

Lines 91 to 94 in 1b87279

	#define PATH_PWDDB SYSCONFDIR "/ksmbd/ksmbdpwd.db"
	#define PATH_SMBCONF SYSCONFDIR "/ksmbd/ksmbd.conf"
	#define PATH_SMBCONF_FALLBACK SYSCONFDIR "/ksmbd/smb.conf"
	#define PATH_SUBAUTH SYSCONFDIR "/ksmbd/ksmbd.subauth"

I understand there was only meant to be one ksmbd running on a system, but with network namespaces, this would be a nice thing to have.

[namjaejeon]

@atheik Can you answer about this question ?

[atheik]

@farnoy,

Sure, I don't see why not. It could be both a global parameter and an option, with the latter having precedence. I am not familiar with the network namespaces use case, but I am guessing you would want runtime control of the subauth file as well?

[farnoy]

I don't remember what I meant about network namespaces. I'm not interested in that personally. Just wanted to specify the state & configuration files at runtime and not have it hardcoded to the constant value at compile time.