Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2 heatmap breaks when match history was previously private #7

Open
CodyFitzpatrick opened this issue Oct 30, 2019 · 2 comments
Open

Comments

@CodyFitzpatrick
Copy link

CodyFitzpatrick commented Oct 30, 2019

I change my game history back and forth between private and public from time to time, and noticed the below when I went to check my heatmap today (yes, I am fortunate enough to be able to play a lot):

Broken Heatmap for D2 - Network Error
Broken Heatmap for D2 - Console Error

@CodyFitzpatrick
Copy link
Author

The easy solution is to skip over data returned from the bungie API if it is error code 1665 or if there is no object returned and that object is not a string. Could be done via a simple "if" clause while populating the heatmap unless I'm missing something big.

@CodyFitzpatrick
Copy link
Author

P.S. I'm not sure if the application is trying to store all history within a single variable, but for a guardian nearing 2000 hrs of playtime, I can't imagine it'd fare well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant