New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rand() used to generate secret #13

Open

rbuetzer opened this issue Sep 17, 2014 · 0 comments

rbuetzer commented Sep 17, 2014

The PHP builtin method rand() is used to generate the secret in https://github.com/chregu/GoogleAuthenticator.php/blob/master/lib/GoogleAuthenticator.php#L78. The PHP docs state «This function does not generate cryptographically secure values, and should not be used for cryptographic purposes. If you need a cryptographically secure value, consider using openssl_random_pseudo_bytes() instead.»

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment