[BUG] Uninstall-ChocolateyPackage.ps1 does not use the msifile

[DennisHarper]

The msi file is never set as an arguement when trying to uninstall. Thus, when msiexec is called, it is just passed /x as well as any other flags, but the file is never passed.

The symmetrical code can be used as an example (Install-ChocolateyInstallPackage.ps1):
Line:58
if ($fileType -like 'msi') {
$msiArgs = "/i "$file""

However, Uninstall-ChocolateyPackage.ps1 has:
Line: 50

if ($fileType -like 'msi') {
$msiArgs = "/x"

[ferventcoder]

Thanks for reporting this!

[rismoney]

@ferventcoder - i left that out intentionally, because I left it to the package author.
Not every package uninstalls via filename.

Uninstall-ChocolateyPackage '7zip' 'msi' '{23170F69-40C1-2702-0920-000001000000} /norestart /qn'

Our oldest PR, actually can use the learned guid, so the author doesn't need to specify it... :)

[ferventcoder]

Our oldest PR is older than my youngest child. x)

[PaulMead]

So what is the correct way to use this helper for MSI's then? Currently with v0.9.8.23 of Chocolatey, using something like : Uninstall-ChocolateyPackage $packageName $fileType $silentArgs "$url"
Fails as the command it generates is of the form:
MSIEXEC /x $silentArgs $url
But should be
MSIEXEC /x $url $silentArgs

Have I missed something with regards to how this helper should be used?

[gep13]

For EXE's, I use this helper command as per here:

https://github.com/chocolatey/chocolatey-coreteampackages/blob/master/feeddemon/tools/chocolateyUninstall.ps1

For MSI's, I typically do something like his:

https://github.com/chocolatey/chocolatey-coreteampackages/blob/master/calibre/tools/chocolateyUninstall.ps1

Gary

[ferventcoder]

@gep13 how does this work on a 32 bit system? https://github.com/chocolatey/chocolatey-coreteampackages/blob/master/feeddemon/tools/chocolateyUninstall.ps1#L8 ;)

[ferventcoder]

@PaulMead It could be a bug in the helper.

[gep13]

@ferventcoder This is a known issue, that I need to figure out. Some testing required here.

[ferventcoder]

:)

[rismoney]

@ferventcoder are you referring to HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall

[PaulMead]

@gep13 Thanks for the help, the second method you suggested worked for the msi

[ferventcoder]

This has been moved over to choco - chocolatey/choco#229