Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature suggestion: show prop removal #98

Open
edygarOliveira opened this issue Sep 1, 2017 · 2 comments
Open

Feature suggestion: show prop removal #98

edygarOliveira opened this issue Sep 1, 2017 · 2 comments

Comments

@edygarOliveira
Copy link

edygarOliveira commented Sep 1, 2017 •
edited
Loading

Is there a reason for show prop? I mean, couldn't the mount and unmount of the component serve as show toggle? Besides the fact it's easier to manage (no more listen to history or anything like that) what is the point of having the Swal mounted if not showing it? I can't think of any single good reason by now
@chentsulin
Copy link
Owner

chentsulin commented Sep 11, 2017 •
edited
Loading

Because swal-overlay will not be removed even after we close it, it's a side effect.

2017-09-11 10 56 36

Using mount and unmount of the component to control sweetalert is a good idea. We can remove swal-overlaymanually when willUnmount

@nick9822
Copy link

JFYI I tried with mounting and unmounting it works good, but when unmounting not just swal-overlay sweet-alert also needed to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chentsulin @nick9822 @edygarOliveira