Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prop-types library to devDependencies #54

Open
eugef opened this issue Jan 2, 2019 · 4 comments
Open

Move prop-types library to devDependencies #54

eugef opened this issue Jan 2, 2019 · 4 comments

Comments

@eugef
Copy link

eugef commented Jan 2, 2019

As react and react-dom are already defined as devDependencies i propose to to the same with prop-types.

Are there any cons?

@nkbt
Copy link
Collaborator

nkbt commented Jan 2, 2019

prop-types are used in prod build, but react-dom is not. So they have to be in deps.
Alternatively in peer deps

@eugef
Copy link
Author

eugef commented Jan 3, 2019

react is also used in prod build but it is not in dependencies list. This makes sense and allows to avoid transitive dependencies and ending up with multiple instances of react in one project.

The same approach should work for prop-types - moving it to devDependencies and peerDependencies

@nkbt
Copy link
Collaborator

nkbt commented Jan 4, 2019

yeah, peer deps would do just fine

@eugef
Copy link
Author

eugef commented Feb 27, 2019

@nkbt please review my PR #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants