We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This gem breaks for rails HEAD version (e.g. 7.1), instead of usual hash structure, we're getting string representation of a hash structure.
Issue was discovered in this PR #19
appraisal install
appraisal rake
Following errors are returned for tests that run against rails head.
Error: PbbuilderTemplateTest#test_nested_message_partial: NoMethodError: undefined method `best_friend' for "<API::Person: name: \"Chris Harris\", friends: [], best_friend: <API::Person: name: \"Max Verstappen\", friends: [], nicknames: [], favourite_foods: {}>, nicknames: [], favourite_foods: {}>":String assert_equal "Max Verstappen", result.best_friend.name ^^^^^^^^^^^^ /Users/skatkov/Code/pbbuilder/test/pbbuilder_template_test.rb:77:in `block in <class:PbbuilderTemplateTest>'
Error: PbbuilderTemplateTest#test_basic_template: NoMethodError: undefined method `name' for "<API::Person: name: \"hello\", friends: [], nicknames: [], favourite_foods: {}>":String assert_equal "hello", result.name ^^^^^ /Users/skatkov/Code/pbbuilder/test/pbbuilder_template_test.rb:26:in `block in <class:PbbuilderTemplateTest>'
Instead of a hash structure returned as it was before, now string representation of hash is being returned.
The text was updated successfully, but these errors were encountered:
It looks like we are not alone - the ActionView API has changed and it converts rendered data into strings
rails/rails#50930
In a way this would be an interesting excercise (a proto message is a string of bytes after all) but at what cost?
Sorry, something went wrong.
And this got fixed upstream in rails/rails#51023 @skatkov can you check whether it works again?
Successfully merging a pull request may close this issue.
Description
This gem breaks for rails HEAD version (e.g. 7.1), instead of usual hash structure, we're getting string representation of a hash structure.
Issue was discovered in this PR #19
Steps
appraisal install
appraisal rake
Result
Following errors are returned for tests that run against rails head.
Expected result
Instead of a hash structure returned as it was before, now string representation of hash is being returned.
The text was updated successfully, but these errors were encountered: