Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #149

Open
1 of 7 tasks
Updula opened this issue Jun 29, 2020 · 0 comments
Open
1 of 7 tasks

Improvements #149

Updula opened this issue Jun 29, 2020 · 0 comments

Comments

@Updula
Copy link

Updula commented Jun 29, 2020

  • Enqueue https://pay.google.com/gp/p/js/pay.js script only if google pay is enabled.
  • Add support for any custom checkout fields in ApplePay JS, for example we have a field with name mobile/email which breaks ApplePay popup from working, 1 line fix added to the applepay filed fixed it: if(name === 'mobile/email') { return true; }
  • Show Fawry even if current currency is not EGP, our store supports multiple gateways we don't use EGP as main currency, but we have a converter that makes currency switch to EGP upon Fawry selection. This way we're supporting multiple currencies. issue found in if ($value == 'fawry' && $currencyCode == 'EGP' && $countryCode == 'EG') {
  • Remove shipping label in ApplePay popup unless shipping is set.
  • Add discount label in ApplePay popup if exists.
  • Add fees label in ApplePay popup if exists.
  • Add tax label in ApplePay popup if exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant