Using Path2D #753
stockiNail
started this conversation in
Ideas
Replies: 1 comment
-
As written, I'm going to propose a PR where you could add a curve on the chart as annotation. Any preference? In the meanwhile, I'm going to implement new option to line annotation, because 80% of the code remain the same but some annoying if statements must be introduced. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'm playing with Path2D in order to verify if I can add another annotation type,
curve
. Just playing.And I'm using Path2D mainly because the most difficult part of a curve is to know if a point is
inRange
. Leveraging on Path2D I can useisPointInStroke
method (but alsoisPointInPath
for closed objects) andinRange
is very simple (is also check the borderWidth).I was thinking if you could make sense to go to Path2D. This could simplify some implementations (at least the inRange). The cons are that point and round rect drawings (currently delegated to Chartjs) should be "replicated" in the project.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions