Add license info and github slug to dataset #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukvonStrom Thanks for the contributions. |
|
@LukvonStrom thanks for the contributions. I fixed the problem with the validations. The licenseInfo and githubRepoSlug fields are required but are missing or misplaced. Can you verify that information? |
|
This has been fixed now, I also added assertions to make sure this is constantly ensured. Apologies for the initial, somewhat naive implementation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear bump maintainers,
In this PR which is based on #186, I added the SPDX license identifiers and the clear github slug of the updated dependency and the consuming repository.
In addition I tried to add these changes into the miner as well, but the testsuite kept failing for me, making validation of those changes a bit hard.
I updated the JSON Schema as well.
Best regards,
Lukas