You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current req and pub driver have infinite capacity. This means that if for some reason messages accumulate in the pending requests queue, the application will eventually run out of memory and crash.
We should add some sort of HWM that either blocks or drops messages after a specific capacity is reached.
An option could be to use LruCache instead of the current FxHashMap.
Further improvements include different StorageBackends including layered cache between memory and disk (e.g. LruCache -> RocksDB)
On the subscriber level, a durability Policy settings should be added to indicate if we intend to receive cached messages or just the ones send from the connection point onward.
The text was updated successfully, but these errors were encountered:
Hey @quangkeu95 there's one open PR (#29) that is adding throughput limits which is already something in this direction.
Maybe after that's done we can reevaluate! Thanks for the interest
The current
req
andpub
driver have infinite capacity. This means that if for some reason messages accumulate in the pending requests queue, the application will eventually run out of memory and crash.msg-rs/msg-socket/src/req/driver.rs
Lines 120 to 133 in 10070e6
We should add some sort of HWM that either blocks or drops messages after a specific capacity is reached.
An option could be to use LruCache instead of the current FxHashMap.
Further improvements include different
StorageBackend
s including layered cache between memory and disk (e.g. LruCache -> RocksDB)Edit:
Policy
settings should be added to indicate if we intend to receive cached messages or just the ones send from the connection point onward.The text was updated successfully, but these errors were encountered: