Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidecar): comprehensive transaction validation #253

Open
mempirate opened this issue Oct 2, 2024 · 0 comments
Open

feat(sidecar): comprehensive transaction validation #253

mempirate opened this issue Oct 2, 2024 · 0 comments
Labels
C: bolt-sidecar Component: bolt-sidecar T: chore Type: Chore

Comments

@mempirate
Copy link
Contributor

mempirate commented Oct 2, 2024

Context

We currently do some initial transaction verification like nonce, balance and basefee checks, but this is not enough. See https://github.com/paradigmxyz/reth/blob/2d592125128c3742ff97b321884f93f9063abcb2/crates/transaction-pool/src/validate/eth.rs#L155 for reference.

We can do this in a couple ways:

  • Implement the reth EthTransactionValidator somehow (only works if it doesn't need access to state DB)
  • Use the EL json-rpc to somehow validate incoming transactions beyond what the sidecar does
@mempirate mempirate added C: bolt-sidecar Component: bolt-sidecar T: chore Type: Chore labels Oct 2, 2024
@mempirate mempirate added this to the v0.4: Holesky 2 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-sidecar Component: bolt-sidecar T: chore Type: Chore
Projects
None yet
Development

No branches or pull requests

1 participant