Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation #21

Open
bensoltoff opened this issue Dec 10, 2016 · 0 comments
Open

Evaluation #21

bensoltoff opened this issue Dec 10, 2016 · 0 comments

Comments

@bensoltoff
Copy link
Contributor

Evaluation of final project by Benjamin Soltoff

Topic Excellent Satisfactory Needs Work
Coding style x
Coding strategy x
Presentation: graphs x
Presentation: tables x
Achievement, creativity x
Ease of access x

Remarks:

  • Why use 50 meters as your cut point? Is this a common metric in the literature?
  • Nice use of ggmapto visualize the spatial data
  • Rather than
print(str_c("The ",
            nrow(DivvyData %>% filter(from_prox == 1))/nrow(DivvyData)*100,
            "% of all Divvy trips are made from stations in proximity with one CTA stop or more."))

which prints the text as an R comment, directly integrate using in-line R code, like this:

`r nrow(DivvyData %>% filter(from_prox == 1))/nrow(DivvyData)*100`% of all Divvy trips are made from stations in proximity with one CTA stop or more.
  • Great use of R to collect and visualize the data, but I'm missing the research question. What am I learning from this analysis? There are multi-modal trips and non-multimodal trips, but how is that important? Do we know what causes individuals to take multimodal trips? What is the value of the research? That isn't established here
  • Well-documented code, and the readme is very helpful in describing the project and how all the files work together. Nice work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant