Rotation fails on files that already end in .1

[kkjdroid]

Trying to rotate error.log.1 will sometimes result in an error.log.1.1, but if error.log.1.1 exists then trying to rotate error.log.1 will produce no new file and will not call either the then() or the catch() callback.

[cesargb]

I've tried to replicate the problem but I can't. I have published a PR #11 with a test for this issue, but the tests pass and calls to the then method occur correctly.

Could you tell me what version you have installed and what platform does it run on?

[kkjdroid]

Odd. I'm on PHP 7.4.3 and Ubuntu 20.04.3 and it happens very consistently.

[cesargb]

@kkjdroid , Could you tell me what version of the package you have installed?

[kkjdroid]

2.4.0

[cesargb]

I just published version 2.5.0, where you have a new method finally, this method is always called when the process ends. One possible case is when the source file does not exist, in which case no exception is thrown and no rotation occurs.

Please, update the package and test with:

$rotation = new Rotation();

$rotation->finally(function($message) {
   echo $message. PHP_EOL;
})->rotate('error.log.1');

[kkjdroid]

~~Oddly, it seems to work perfectly fine now. Thanks for your help with this issue.~~

[kkjdroid]

It's now very inconsistent. I got debug.log.1.1 to rotate to debug.log.1.1.1 and then debug.log.1.1.2, but now it won't create debug.log.1.1.3.

Here is my code:

debug_log('test');
$new_path = (new Rotation)
    ->compress(false)
    ->files(366)
    ->minSize(0)
    ->then(function($new_path, $old_path)
    {
        debug_log($new_path);
        debug_log($old_path);
        file_put_contents($old_path, '');
        return $new_path;
    })
    ->catch(function($e)
    {
        debug_log('then');
        debug_log($e);
    })
    ->finally(function($message)
    {
        debug_log('finally');
        debug_log($message);
    })
    ->rotate($path);

And the log output that it creates:

'test'

2022-01-26T10:39:25-05:00
'test'

2022-01-26T10:39:42-05:00
'test'

2022-01-26T10:41:04-05:00
'test'

2022-01-26T10:41:56-05:00
'test'

2022-01-26T10:41:56-05:00
'finally'

2022-01-26T10:41:56-05:00
'sucessfull'

2022-01-26T10:41:56-05:00
'debug.log.1.1'

2022-01-26T10:41:56-05:00
'debug.log.1'

2022-01-26T10:42:24-05:00
'test'

2022-01-26T10:42:24-05:00
'finally'

2022-01-26T10:42:24-05:00
'sucessfull'

2022-01-26T10:42:24-05:00
'debug.log.1.1.1'

2022-01-26T10:42:24-05:00
'debug.log.1.1'

2022-01-26T10:42:40-05:00
'test'

2022-01-26T10:43:02-05:00
'test'

2022-01-26T10:43:15-05:00
'test'

2022-01-26T10:43:31-05:00
'test'

2022-01-26T10:43:57-05:00
'test'

2022-01-26T10:43:57-05:00
'finally'

2022-01-26T10:43:57-05:00
'sucessfull'

2022-01-26T10:43:57-05:00
'error.log.1'

2022-01-26T10:43:57-05:00
'error.log'

2022-01-26T10:44:18-05:00
'test'```