Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce strong formatting & linting aka black/ruff #2515

Open
kamil-certat opened this issue Jul 16, 2024 · 0 comments
Open

Introduce strong formatting & linting aka black/ruff #2515

kamil-certat opened this issue Jul 16, 2024 · 0 comments

Comments

@kamil-certat
Copy link
Contributor

IntelMQ has a very weak formatting/linting rules what is not a typical thing in modern development, where projects tend to provide strict & automated formatting to keep the code style consistent.

Especially in Python world, there is a general movement last years to implement the black formatter, and currently most black-compatible ruff formatter, which also replace some other tools, like isort.

I'd like to introduce ruff with import sorting enabled in IntelMQ. This would provide a consistent code style without much developer action required as black/ruff enforces the style automatically. The code style is compliant with PEP8, and in addition lowers the number of git conflicts, removes unused imports, and can be fully configured to support any of our style configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant