Unable to apply config without 'mon_ip' on deployed cluster

[ricardoasmarques]

The /cephadm_bootstrap/mon_ip option is only used for initial deployment, and after that is no longer needed.

But I'm getting an error when trying to execute ceph-salt apply without /cephadm_bootstrap/mon_ip:

master:~ # ceph-salt config ls /cephadm_bootstrap/mon_ip
o- mon_ip .................................................................................................. [not set]

master:~ # ceph-salt status
cluster: 4 minions, 4 hosts managed by cephadm
config:  OK

master:~ # ceph-salt apply 
Syncing minions with the master...
Checking if minions respond to ping...
Pinging 4 minions...
Checking if ceph-salt formula is available...
Formula not found. Do you want to restart 'salt-master' to load 'ceph-salt' formula?  (y/n): [n]: n
Aborted!

master:~ # salt node1.pacific.test state.show_sls ceph-salt
node1.pacific.test:
    - Rendering SLS 'base:ceph-salt.apply.cephbootstrap' failed: Jinja variable 'dict object' has no attribute 'bootstrap_mon_ip'
ERROR: Minions returned with non-zero exit code

master:~ # ceph-salt config ls /
o- / ........................................................................................................... [...]
  o- ceph_cluster .............................................................................................. [...]
  | o- minions .......................................................................................... [Minions: 4]
  | | o- master.pacific.test ........................................................................ [cephadm, admin]
  | | o- node1.pacific.test ..................................................................... [cephadm, bootstrap]
  | | o- node2.pacific.test ................................................................................ [cephadm]
  | | o- node3.pacific.test ................................................................................ [cephadm]
  | o- roles ................................................................................................... [...]
  |   o- admin .......................................................................................... [Minions: 1]
  |   | o- master.pacific.test ................................................................ [Other roles: cephadm]
  |   o- bootstrap .............................................................................. [node1.pacific.test]
  |   o- cephadm ........................................................................................ [Minions: 4]
  |   | o- master.pacific.test .................................................................. [Other roles: admin]
  |   | o- node1.pacific.test ............................................................... [Other roles: bootstrap]
  |   | o- node2.pacific.test ....................................................................... [No other roles]
  |   | o- node3.pacific.test ....................................................................... [No other roles]
  |   o- tuned ................................................................................................. [...]
  |     o- latency ...................................................................................... [no minions]
  |     o- throughput ................................................................................... [no minions]
  o- cephadm_bootstrap ......................................................................................... [...]
  | o- advanced ................................................................................................ [...]
  | o- ceph_conf ............................................................................................... [...]
  | o- ceph_image_path ............................. [registry.opensuse.org/filesystems/ceph/pacific/images/ceph/ceph]
  | o- dashboard ............................................................................................... [...]
  | | o- force_password_update ............................................................................ [disabled]
  | | o- password ............................................................................................ [admin]
  | | o- ssl_certificate ................................................................................... [not set]
  | | o- ssl_certificate_key ............................................................................... [not set]
  | | o- username ............................................................................................ [admin]
  | o- mon_ip .............................................................................................. [not set]
  o- containers ................................................................................................ [...]
  | o- registries_conf ..................................................................................... [enabled]
  | | o- registries .......................................................................................... [empty]
  | o- registry_auth ........................................................................................... [...]
  |   o- password .......................................................................................... [not set]
  |   o- registry .......................................................................................... [not set]
  |   o- username .......................................................................................... [not set]
  o- ssh .............................................................................................. [Key Pair set]
  | o- private_key ................................................. [32:70:09:c8:eb:2c:93:40:bf:95:45:2c:8c:47:82:b8]
  | o- public_key .................................................. [32:70:09:c8:eb:2c:93:40:bf:95:45:2c:8c:47:82:b8]
  o- time_server ........................................................................................... [enabled]
    o- external_servers .......................................................................................... [1]
    | o- pool.ntp.org .......................................................................................... [...]
    o- server_hostname ......................................................................... [master.pacific.test]
    o- subnet ........................................................................................ [10.20.94.0/24]

Workaround: Set mon_ip or remove the bootstrap minion

[smithfarm]

I guess ceph-salt apply should determine whether a cluster has been deployed or not, and if yes, then avoid running the cephbootstrap.sls at all.