From 9193a3dc1624471b86e73a9d6716b41474590eba Mon Sep 17 00:00:00 2001
From: Jeroen Offerijns <jeroen@offerijns.com>
Date: Tue, 13 Aug 2024 15:17:17 +0200
Subject: [PATCH] Clean up file

---
 src/factories/AggregatorV3OracleFactory.sol | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/src/factories/AggregatorV3OracleFactory.sol b/src/factories/AggregatorV3OracleFactory.sol
index e94e0081..07ea79b7 100644
--- a/src/factories/AggregatorV3OracleFactory.sol
+++ b/src/factories/AggregatorV3OracleFactory.sol
@@ -28,23 +28,18 @@ contract VaultOracle is Auth, IAggregatorV3 {
     // --- Administration ---
     function file(bytes32 what, address data) public auth {
         if (what == "vault") {
-            _updateVault(data);
+            require(
+                address(vault) == address(0)
+                    || (IERC7540Vault(data).share() == vault.share() && IERC7540Vault(data).asset() == vault.asset()),
+                "VaultOracle/mismatching-asset-or-share"
+            );
+            vault = IERC7540Vault(data);
             emit File(what, data);
         } else {
             revert("VaultOracle/file-unrecognized-param");
         }
     }
 
-    function _updateVault(address vault_) internal {
-        IERC7540Vault newVault = IERC7540Vault(vault_);
-        require(
-            address(vault) == address(0) || (vault.share() == newVault.share() && vault.asset() == newVault.asset()),
-            "VaultOracle/mismatching-asset-or-share"
-        );
-
-        vault = newVault;
-    }
-
     // --- Price computation ---
     function latestRoundData()
         public