Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ES6 object method shorthand in clabe.js #18

Closed
dpilafian opened this issue Dec 16, 2019 · 2 comments · Fixed by #31
Closed

Switch to ES6 object method shorthand in clabe.js #18

dpilafian opened this issue Dec 16, 2019 · 2 comments · Fixed by #31
Assignees
@wejrox
Labels
enhancement good first issue Good for newcomers help wanted

Comments

@dpilafian
Copy link
Member

dpilafian commented Dec 16, 2019 •
edited
Loading

Upgrade to more modern ES6 function definitions. The newer notation is more compact and looks better.

See MDN web docs:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions
@dpilafian
Copy link
Member Author

dpilafian commented Dec 16, 2019 •
edited
Loading

For example, change:

   computeChecksum: (clabeNum17) => {

to:

   computeChecksum(clabeNum17) {

and then make sure all the tests pass: $ npm test

@dpilafian dpilafian changed the title Switch to ES6 object method shorthand Switch to ES6 object method shorthand in clabe.js Oct 3, 2020
@wejrox
Copy link
Contributor

wejrox commented Oct 4, 2020

Hey, I can do this one but could you register your repository with HacktoberFest by adding the hacktoberfest topic to your repository?

wejrox added a commit to wejrox/clabe-validator that referenced this issue Oct 7, 2020
@wejrox
Switch to ES6 object method shorthand in clabe.js
b09d761 
Fixes center-key#18
@wejrox wejrox mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wejrox wejrox

Labels
enhancement good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to ES6 object method shorthand in clabe.js wejrox/clabe-validator
2 participants
@dpilafian @wejrox