Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to trailing comma style in spec.js #27

Closed
dpilafian opened this issue Oct 3, 2020 · 1 comment · Fixed by #28
Closed

Switch to trailing comma style in spec.js #27

dpilafian opened this issue Oct 3, 2020 · 1 comment · Fixed by #28
Assignees
@wejrox
Labels
good first issue Good for newcomers help wanted

Comments

@dpilafian
Copy link
Member

For multiline arrays and objects, the consistency of including a comma for the last item makes the code easier to edit and helps reduce merge diffs.

See:
https://jshint.com/docs/options/#trailingcomma

For example, change:

const dataSet = [
   { input: '002', expected: 'BANAMEX' },
   { input: '640', expected: 'CB JPMORGAN' },
   { input: '652', expected: 'CREDICAPITAL' }  //no comma
   ];

to:

const dataSet = [
   { input: '002', expected: 'BANAMEX' },
   { input: '640', expected: 'CB JPMORGAN' },
   { input: '652', expected: 'CREDICAPITAL' },  //with comma
   ];
@wejrox
Copy link
Contributor

wejrox commented Oct 4, 2020

Hi, please can you assign me to this issue?

@wejrox wejrox mentioned this issue Oct 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wejrox wejrox

Labels
good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to trailing comma style in spec.js wejrox/clabe-validator
2 participants
@dpilafian @wejrox