Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down Sampling Result Never Used #92

Open
ghost opened this issue Feb 17, 2019 · 0 comments
Open

Down Sampling Result Never Used #92

ghost opened this issue Feb 17, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 17, 2019

Just found that in the twenty_newsgroups example, the downsampled word list is never used after calculation:

clean = corpus.subsample_frequent(pruned)

I fixed this by moving the downsampling to an earlier place and changing all the later "pruned" to "clean", but some preprocessing results like vocab.pkl, corpus.pkl, and vectors are still not influenced by the downsampling and the further solution (if needed) seems not straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants