Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test publish_all = true case #63

Open
gakonst opened this issue Apr 30, 2020 · 1 comment
Open

Test publish_all = true case #63

gakonst opened this issue Apr 30, 2020 · 1 comment

Comments

@gakonst
Copy link
Contributor

gakonst commented Apr 30, 2020

We should add a test for the case where all responses (both successful and complaints) are published. Currently we only test for publish_all = false

Should we also have a test with true and verify we got X responses and Y complaints?

Originally posted by @kobigurk in #61

@nikkolasg
Copy link
Contributor

The paper Pedersen algorithm only posts complaints. The code lays the groundwork for running in what I call "fast sync" mode where we can post success responses as well, such that

  • as soon as we receive n deals we pass to next phase
  • and as soon as we receive n ^2 success we finish dkg
    but the code is not handling that completely right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants