Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in proposal passing threshold #77

Open
Tracked by #78
aaronmgdr opened this issue Oct 17, 2024 · 0 comments
Open
Tracked by #78

Bug in proposal passing threshold #77

aaronmgdr opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aaronmgdr
Copy link
Member

Description

proposal #189:
mondo.celo.org shows needing 7,326,086 CELO to pass quorum
whereas celo.stake.id and celocli on show needing 4,395,652.

info

because of the complexity of dermining what passing means relies on a number of factors including params for what is changing by proposal, the number of votes last few referenda. etc. it is very difficult to get this right. the code used by the contract is not exposed which means we must re implement it.

Ideally we would make an upgrade to governance.sol but that seems unlikely.

Alternative solution could be just just call isPassing function and if is true assume that one is correct. t

@aaronmgdr aaronmgdr added the bug Something isn't working label Oct 17, 2024
@aaronmgdr aaronmgdr added this to the 5 - Celo MVP Mainnet milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants