Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v1.x to the latest celestiaorg/cosmos-sdk release #3448

Closed
rootulp opened this issue May 8, 2024 · 1 comment
Closed

Upgrade v1.x to the latest celestiaorg/cosmos-sdk release #3448

rootulp opened this issue May 8, 2024 · 1 comment
Assignees
Labels
WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@rootulp
Copy link
Collaborator

rootulp commented May 8, 2024

Context

Not sure how I missed this but celestiaorg/cosmos-sdk#376 contains a breaking change to the function AppVersion that we released in a patch version: https://github.com/celestiaorg/cosmos-sdk/releases/tag/v1.20.2-sdk-v0.46.16

Problem

v1.x and main are currently on different Cosmos SDK releases and bumping v1.x to use the latest Cosmos SDK release involves addressing the breaking change. I actually tried to do that in #3177 but it wasn't trivial so I closed the PR without root causing all the issues.

Proposal

Bump the Cosmos SDK dep on the v1.x branch.

@rootulp rootulp added the WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc label May 8, 2024
@rootulp rootulp self-assigned this May 30, 2024
rootulp added a commit that referenced this issue May 31, 2024
Closes #3448
Unblocks celestia-node because this cosmos-sdk release contains
celestiaorg/cosmos-sdk#401 which should let
celestia-node upgrade their `prometheus/common` dependency.
@rootulp
Copy link
Collaborator Author

rootulp commented Jun 4, 2024

Closed by #3517

@rootulp rootulp closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Development

No branches or pull requests

2 participants