Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same target could be used by several filesystems with File backend #130

Open
degremont opened this issue Jun 5, 2012 · 6 comments
Open
Milestone

Comments

@degremont
Copy link
Collaborator

In File backend mode, shine install and format actions do not check if targets declared in a filesystem are available. By available, I mean free from any other filesystem configuration.
"shine status" detects this situation, though.
I don't know if the test can be done as early as "shine install" but, maybe "shine format" could display an error and exit, or at least prompt the user before resuming execution ?.

Reported by: theryf

@degremont
Copy link
Collaborator Author

        priority
            changed from major to minor

Replying to theryf:

"shine status" detects this situation, though.
I don't know if the test can be done as early as "shine install" but, maybe "shine format" could display an error and exit, or at least prompt the user before resuming execution ?.

shine status does active checking on target device and ensure that the current device is coherent with what is describe in the model.
shine format could be used to reformat an existing filesystem or replace a previous one by a new one. In this case it is normal that the current device is not coherent with what is described in shine configuration. It is impossible to "guess", by shine format, is what is present on the device is coherent or not.

In File backend mode, shine install and format actions do not check if targets declared in a filesystem are available. By available, I mean free from any other filesystem configuration.

The only place where this check could be done is in shine install. This means that the File backend mode should be improved with a cache, storing for each target if it is used or not. This should be kept coherent when storage.conf is modified. This is close to what a cluster DB backend does. However, this has side effect and cache coherency issue I'm not sure we want to be faced to.
We have to though about it but I'm not sure we will support this.

Original comment by: degremont

@degremont
Copy link
Collaborator Author

  • summary: shine allows the same target to be used by several filesystems --> Same target to be used by several filesystems with File backend
  • Description has changed:

Diff:




  • Resolution: -->

Original comment by: degremont

@degremont
Copy link
Collaborator Author

  • summary: Same target to be used by several filesystems with File backend --> Same target could be used by several filesystems with File backend

Original comment by: degremont

@degremont
Copy link
Collaborator Author

  • Milestone: 1.3 --> 1.4

Original comment by: degremont

@degremont
Copy link
Collaborator Author

  • Milestone: 1.4 --> 1.5

Original comment by: degremont

@degremont
Copy link
Collaborator Author

  • Milestone: 1.5 --> 1.6

Original comment by: degremont

@degremont degremont added this to the 1.6 milestone May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant