-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same target could be used by several filesystems with File backend #130
Comments
Replying to theryf: "shine status" detects this situation, though. shine status does active checking on target device and ensure that the current device is coherent with what is describe in the model. In File backend mode, shine install and format actions do not check if targets declared in a filesystem are available. By available, I mean free from any other filesystem configuration. The only place where this check could be done is in shine install. This means that the File backend mode should be improved with a cache, storing for each target if it is used or not. This should be kept coherent when storage.conf is modified. This is close to what a cluster DB backend does. However, this has side effect and cache coherency issue I'm not sure we want to be faced to. Original comment by: degremont |
Diff:
Original comment by: degremont |
Original comment by: degremont |
Original comment by: degremont |
Original comment by: degremont |
Original comment by: degremont |
In File backend mode, shine install and format actions do not check if targets declared in a filesystem are available. By available, I mean free from any other filesystem configuration.
"shine status" detects this situation, though.
I don't know if the test can be done as early as "shine install" but, maybe "shine format" could display an error and exit, or at least prompt the user before resuming execution ?.
Reported by: theryf
The text was updated successfully, but these errors were encountered: