Re-add support for tonic #54
Conversation
sjoerdsimons
force-pushed
the
re-add-tonic
branch
from
ec68673 to
ae7c75f
Compare
|
The CI test fails as prost has a MSRV of 1.70; I guess to solve this we can either update the MSRV of this crate to match or only support leave it 1.68 as long as tonic is not supported Fwiw 1.70 was release in june last year, while 1.68 was march last year |
|
Just checked the MSRV policies of other players in the eco system.
imho it is fair to upgrade this crates one to 1.70 (as over one year passed) but it would be higher than axum's. |
sjoerdsimons
force-pushed
the
re-add-tonic
branch
5 times, most recently
from
3693d8d to
733d9c4
Compare
Actually turns out the jsonwebtoken 9.3 already needs rust 1.73 regardless... So bumped to that now and only changed CI to only check the library build (msrv of the dev-dependency is typically not relevant) |
|
kindly ping @cduvray for approval and release |
|
Hi, Ok for MSRV (I think I had errors even with 1.73, du to a dependency, the version 1.75 solves this), but in your commit I think no tests are run for the version MSRV is this what you want? I think tests should be run also for MSRV, |
Nothing in the layer implementation actually depends on the Request's body type. So generalise over the body type, allowing the service implementation not longer be tied to axum specifically.
Now that tonic support has been re-added, update as required for the new/latest version with.
The test end up depending on crates requiring more recent rust, but for msrv really only the library itself is important. Also bump to 1.73 as that's the minimal required for the jsonwebtoken dependency
sjoerdsimons
force-pushed
the
re-add-tonic
branch
from
733d9c4 to
0d10856
Compare
Done! Downside ofcourse that bisectability isn't as good but such is life :)
Yes the goal was to only build the library with MSRV to ensure it can be compiled with that rust version; The problem with also running tests on MSRV is that all the dev-dependencies then need a compatible MSRV as well, which imho is harder to maintain and less relevant for crate users. |
|
The revert that landed on main put axum 6 back into the game: #56 |
|
I've partially merged it (to have a usable main, and to solve #56), I'm not yet sure about CI and MSRV, I have to think about it. |
Thanks! If you don't want to take these CI changes at the moment the easiest fix to get CI on main green again is likely to bump up msrv to 1.75 (not tested). Fwiw this also shows the issue i was trying to fix as fundamentally now your MSRV is driven by your dev-dependencies instead (iirc through wiremock) rather then the actual library dependencies |
|
Hello, I've rewritten the CI bumping msrv to 75. |
Now that tonic with hyper 1.0 is available re-add the support that was temporarily removed
Fixes #52