Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocked attribute on non User models #789

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

AntoineAugusti
Copy link
Contributor

@AntoineAugusti AntoineAugusti commented Oct 13, 2020

Fixes cds-snc/notification-api#1154

The blocked attribute was added to various models that don't support it: org, service, InvitedUser, InvitedOrgUser. The only model using this attribute is the User model.

This extra attribute was responsible for a bug I encountered while working on another feature. I fixed it at the same time because I already investigated the root cause.

@maxneuvians maxneuvians temporarily deployed to notification-blocked-at-fcxtzx October 13, 2020 20:32 Inactive
@AntoineAugusti AntoineAugusti marked this pull request as ready for review October 14, 2020 13:48
Copy link
Contributor

@brdunfield brdunfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@AntoineAugusti AntoineAugusti merged commit ee65668 into master Oct 14, 2020
@AntoineAugusti AntoineAugusti deleted the blocked-attribute-non-user-model branch October 14, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to accept an org invite: KeyError blocked
3 participants