feat: set cache headers for static assets #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # as they have unique hashes thanks to the asset | ||
| # fingerprinter | ||
| if request.url.startswith(asset_fingerprinter._asset_root): | ||
| response.headers.add('Cache-Control', 'public, max-age=31536000, immutable') |
There was a problem hiding this comment.
just so you are aware: immutable is only support on Firefox, Safari
There was a problem hiding this comment.
Followed recommendations from MDN yeah https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#caching_static_assets + https://web.dev/http-cache/#versioned-urls
QuanNguyen-CDS
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cds-snc/notification-api#1152
This PR adds appropriate
Cache-Controlheaders for static assets (JS, CSS, images) served by the admin. This will improve the user experience for users, reduce the number of requests we have to handle and our costs.Cache invalidation is done thanks to an asset fingerprinter. I've made sure that templates don't use hardcoded paths anymore by looking for thinks like
static/,asset_pathandadmin_base_urlin the codebase.