Whitespace disappears before vertical bar in email subject headings

[pcraig3]

Hello!

We are trying to send a subject line like Change your password | COVID Alert Portal, but the template strips the whitespace before the vertical bar.

While editing, it looks right:

But then on the "view template" screen, you can see the space is missing for the subject heading. (Not the sender though.)

Interestingly, it's also affecting your account modification email subject headings.

Again, pretty minor bug but I figured I should mention it.

[AntoineAugusti]

Encountered this as well and it's annoying, even if it's a little thing

[AntoineAugusti]

Investigated a bit this issue and it's caused by the fact that there are a few rules to clean what's written in subject/body. Enforcing a space after a comma/dot, removing a space before a pipe (this bug) and many others.

The regex causing the pipe problem is here https://github.com/cds-snc/notification-utils/blob/39eb59a9b6befc5f6ad50d74f03ed277c858c9be/notifications_utils/formatters.py#L65. The subject field is cleaned this way https://github.com/cds-snc/notification-utils/blob/39eb59a9b6befc5f6ad50d74f03ed277c858c9be/notifications_utils/template.py#L275-L285. The rule we are interested in is remove_whitespace_before_punctuation.

I'd be in favour of removing the pipe from the list. It seems acceptable to have whitespace before a pipe.

@bryan-robitaille if you want to review other rules, they are located in this file https://github.com/cds-snc/notification-utils/blob/master/notifications_utils/template.py and method names read nicely