Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-built Lambda broken on version 3.0.0, fixed in 3.0.1 #461

Closed
SamStephens opened this issue Dec 20, 2023 · 1 comment · Fixed by #462
Closed

Pre-built Lambda broken on version 3.0.0, fixed in 3.0.1 #461

SamStephens opened this issue Dec 20, 2023 · 1 comment · Fixed by #462

Comments

@SamStephens
Copy link
Contributor

SamStephens commented Dec 20, 2023

Version 3.0.0 renamed the main executable file from main to bootstrap, as this is the executable the AL2023 Lambda runtime expects.

However as per #424 (comment) (thanks @yito-dev-tokyo), a required update to the scripting for using the prebuilt Lambda [*] was missed. Unfortunately by it's nature, the updates to this scripting were not testable without releasing a new version of the cdk-ecr-deployment package.

const bin = path.join(dir, 'main');

Should be

const bin = path.join(dir, 'bootstrap');

Part of the release criteria for this fix from this should be a successful deploy of the Lambda with FORCE_PREBUILT_LAMBDA enabled, to ensure there are no other bugs in the prebuilt Lambda functionality that were missed.

Workaround: to work around this bug, set the NO_PREBUILT_LAMBDA environment variable as per https://github.com/cdklabs/cdk-ecr-deployment#environment-variables to avoid the prebuilt functionality entirely.

[*] By default, the prebuilt Go executable from the Github release is downloaded and used, to avoid having to do your own build.

@SamStephens
Copy link
Contributor Author

@scanlonp it might be worth updating the README to explain this in the meantime, or perhaps to make this a sticky issue to make it easier for users to discover the workaround.

@SamStephens SamStephens changed the title As of version 3, the pre-built Lambda functionality does not work As of version 3.0.0, the pre-built Lambda functionality does not work Dec 20, 2023
@scanlonp scanlonp pinned this issue Dec 20, 2023
@scanlonp scanlonp changed the title As of version 3.0.0, the pre-built Lambda functionality does not work The pre-built Lambda functionality does not work on version 3.0.0, fixed in 3.0.1 Dec 20, 2023
@scanlonp scanlonp changed the title The pre-built Lambda functionality does not work on version 3.0.0, fixed in 3.0.1 Pre-built Lambda broken on version 3.0.0, fixed in 3.0.1 Dec 20, 2023
@wchaws wchaws unpinned this issue Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant