-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-built Lambda broken on version 3.0.0, fixed in 3.0.1 #461
Comments
@scanlonp it might be worth updating the README to explain this in the meantime, or perhaps to make this a sticky issue to make it easier for users to discover the workaround. |
SamStephens
changed the title
As of version 3, the pre-built Lambda functionality does not work
As of version 3.0.0, the pre-built Lambda functionality does not work
Dec 20, 2023
wchaws
added a commit
that referenced
this issue
Dec 20, 2023
scanlonp
changed the title
As of version 3.0.0, the pre-built Lambda functionality does not work
The pre-built Lambda functionality does not work on version 3.0.0, fixed in 3.0.1
Dec 20, 2023
scanlonp
changed the title
The pre-built Lambda functionality does not work on version 3.0.0, fixed in 3.0.1
Pre-built Lambda broken on version 3.0.0, fixed in 3.0.1
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version 3.0.0 renamed the main executable file from
main
tobootstrap
, as this is the executable the AL2023 Lambda runtime expects.However as per #424 (comment) (thanks @yito-dev-tokyo), a required update to the scripting for using the prebuilt Lambda [*] was missed. Unfortunately by it's nature, the updates to this scripting were not testable without releasing a new version of the cdk-ecr-deployment package.
cdk-ecr-deployment/lambda/install.js
Line 48 in 0debc23
Should be
Part of the release criteria for this fix from this should be a successful deploy of the Lambda with
FORCE_PREBUILT_LAMBDA
enabled, to ensure there are no other bugs in the prebuilt Lambda functionality that were missed.Workaround: to work around this bug, set the NO_PREBUILT_LAMBDA environment variable as per https://github.com/cdklabs/cdk-ecr-deployment#environment-variables to avoid the prebuilt functionality entirely.
[*] By default, the prebuilt Go executable from the Github release is downloaded and used, to avoid having to do your own build.
The text was updated successfully, but these errors were encountered: