Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the question of lazy loading #576

Open
graeme-winter opened this issue Nov 10, 2022 · 2 comments
Open

Revisit the question of lazy loading #576

graeme-winter opened this issue Nov 10, 2022 · 2 comments

Comments

@graeme-winter
Copy link
Collaborator

And - ideally - find a better solution perhaps derived from the load before heat death fixes perhaps with a neat way of having per-experiment wavelengths.

@graeme-winter
Copy link
Collaborator Author

#118 for reference

@jbeilstenedmands
Copy link

I was thinking about Graeme's suggestion of using the format_kwargs as a solution to the blocker encountered in dials/dials#2273.

I think this is how such a solution might look: main...jbeilstenedmands:dxtbx:lazy_restructure
Basically the formats that are currently lazy should check for a lazy= kwarg, (with a default of True), removing the need to inherit from FormatMultiImageLazy.

The benefit here over the current approach is that it allows one to switch on/off the lazy behaviour for a given format class by supplying format_kwargs (for example in a call to the make_imageset, make_sequence methods of ImageSetFactory. Currently lazy is forced to be True for classes that inherit from FormatMultiImageLazy, which then puts restrictions on the underlying imageset datastructures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants