Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #1

Open
zxc0328 opened this issue Mar 29, 2018 · 1 comment
Open

Review #1

zxc0328 opened this issue Mar 29, 2018 · 1 comment

Comments

@zxc0328
Copy link
Member

zxc0328 commented Mar 29, 2018

  • 和图书馆那边一样,只要一层目录就行。把多的那层拿掉。拿掉之后submodule应该需要重新配置。
  • 加入Prettier配置。
  • UI上CSS有问题。底部背景Image上面可以绝对定位一个和Image同样大小的框。然后这个框里面用正常的flex布局就可以了。
  • 图片可以引用本地的话还是用本地的比较好。
  • App.css没有用到就删了。
@fengzi2016
Copy link
Collaborator

除了4其它搞定了,只是
如果图片引用本地的会报错;如果发布到新浪上会把透明变成白底,而且怕新浪崩了;如果用base64结果太长了,一个图片大概有100多行的base64,所以打算发布到七牛上。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants