Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you make a custom version with independent configuration settings? #498

Open
chrisdukes opened this issue Aug 26, 2024 · 2 comments

Comments

@chrisdukes
Copy link

I made a custom version of the Comic Vine Scraper by modifying the original version and removing the Welcome Form from the scrapeengine.py file. That's worked great for me, but the problem if that I also have the Original Version of the plugin installed. I assumed they would have independent configurations, but if I change the settings for my Custom Version then Original Version's settings change also. I thought changing the names of the configform.py and configuration.py files along with their references would work, but it's didn't.

Thanks for any help!

@cbanack
Copy link
Owner

cbanack commented Aug 28, 2024

The location of the settings file and other files are all kept resources.py.

If you're trying to make a second version of Comic Vine Scraper, I'd recommend changing the Profile dir (lines 95 to 99) to something other than r"\Comic Vine Scraper". Maybe r"\Comic Vine Scarper Plus" or something. Then all the various settings and stuff will be stored there instead of shared between both versions of the scraper.

While you're at it, things will work smoother if you rename the entire module, which will make ComicRack see the the original scraper and your new scraper as two totally different plugins. To do that, change the Name (and probably author, version, etc) in the Package.ini file.

Of course, then you'll want to rebuild the your own new installer package, but then you need to install IronPython on your system path, as well as Java and Ant to run the build script (build.xml). That requires more specialized knowledge.

@chrisdukes
Copy link
Author

Thanks for the help! It worked out great.

@github-staff github-staff deleted a comment from mayank785 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@cbanack @chrisdukes and others