Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape Last Modified Date #441

Open
Xelloss-nakama opened this issue Jul 21, 2016 · 3 comments
Open

Scrape Last Modified Date #441

Xelloss-nakama opened this issue Jul 21, 2016 · 3 comments

Comments

@Xelloss-nakama
Copy link

Xelloss-nakama commented Jul 21, 2016

It would be useful to add a date in the "scraped" note field saying when was the comic scraped (as new comic info is usually added weeks after the time we scraped some comics)

For example: Scraped metadata from ComicVine [CVDB459159] on 12/12/15 -> when we scrapped it

Also, if possible, it would be useful and option to add when was the comicvine page from where we are scraping the info last modified... (which I think is a field in the api), so we know which comic info was modified from our last scrap

For example: Scraped metadata from ComicVine [CVDB459159] on 12/12/15 (web last modified 12/1/15) -> when the info was last updated in the site

@Xelloss-nakama
Copy link
Author

ok, I see now that the first option was already a feature with an advance option... sorry XD

@boshuda
Copy link

boshuda commented Jul 21, 2016

I actually modified my personal copy of the scraper to add a custom field to save the last scraped time. I'm so lazy, and find github to be confusing enough, that I haven't created a patch (pull?) request. Maybe I'll get off my lazy ass and do it, but probably not.

image

To your second point: I believe comicvine doesn't indicate when the entry was last updated in the API. They might put it on the web page, but that would require web-scraping, which got the app temporarily banned a while ago. However, I'm not sure about that.

@Xelloss-nakama
Copy link
Author

I look at the api documentation yesterday and it does now

@cbanack cbanack changed the title Add dates in notes Scrape Last Modified Date Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants