Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window manager view rendering Material3 Compose Bottom Sheet over AccessibilityRenderExtension info. #1634

Closed
geoff-powell opened this issue Oct 15, 2024 · 3 comments · Fixed by #1637
Assignees
Labels
bug Something isn't working
Milestone

Comments

@geoff-powell
Copy link
Collaborator

geoff-powell commented Oct 15, 2024

Description
When bumping LayoutLib dependency to 14.0.11+, Material3 bottom sheets render overtop the render extension metadata. This issue is to investigate a possible fix. Ignoring the test modalBottomSheetMaterial3 in this LayoutLib bump PR till this issue is resolved.
Image

Steps to Reproduce

  • Remove @ignore in modalBottomSheetMaterial3() in compose-a11y test project test foile.
  • Run composeA11y test in PaparazziGradlePluginTest.kt.

Expected behavior
Snapshot is unchanged.

Additional information:

  • Paparazzi Version: 1.3.5 (renovate/layoutlib)
  • OS: Mac OS
  • Compile SDK: 34
  • Gradle Version: 8.7.1
  • Android Gradle Plugin Version: 8.4.2

Screenshots
See above

@geoff-powell geoff-powell added the bug Something isn't working label Oct 15, 2024
@geoff-powell geoff-powell self-assigned this Oct 15, 2024
@geoff-powell geoff-powell added this to the 1.4 milestone Oct 15, 2024
@jrodbx jrodbx modified the milestones: 1.4, 1.3.5 Oct 15, 2024
@jrodbx
Copy link
Collaborator

jrodbx commented Oct 15, 2024

@geoff-powell since this is a known regression, can we get this fix in for 1.3.5?

@geoff-powell
Copy link
Collaborator Author

@geoff-powell since this is a known regression, can we get this fix in for 1.3.5?

Yeah, let me take a look at this today

@geoff-powell
Copy link
Collaborator Author

geoff-powell commented Oct 15, 2024

WindowManagerImpl change is the root cause from 14.0.9 -> 14.0.11. (line 105) https://www.diffchecker.com/fHBDkOTq/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants